refactor: split main.rs in tee-launcher crate#2633
Merged
Conversation
4 tasks
Code ReviewClean mechanical refactoring — code moved verbatim from ✅ Approved — no critical issues found. |
netrome
requested changes
Mar 27, 2026
Collaborator
netrome
left a comment
netrome
left a comment
There was a problem hiding this comment.
While we do this, I'd prefer to split out all crates to a lib.rs crate.
…factor-mainrs-into-smaller-logical-modules
SimonRastikian
approved these changes
Mar 27, 2026
Comment on lines
+90
to
+99
| match std::fs::OpenOptions::new() | ||
| .read(true) | ||
| .write(false) | ||
| .open(IMAGE_DIGEST_FILE) | ||
| { | ||
| Err(err) if err.kind() == std::io::ErrorKind::NotFound => { | ||
| tracing::warn!( | ||
| ?err, | ||
| ?default_image_digest, | ||
| "approved hashes file does not exist on disk, falling back to default digest" |
Contributor
There was a problem hiding this comment.
This seems not to be similar to what has been deleted...
gilcu3
deleted the
2609-rust-launcher-refactor-mainrs-into-smaller-logical-modules
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2609